Skip to content

feat(chips): allow set in separatorKeyCodes #12477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 3, 2018
Merged

feat(chips): allow set in separatorKeyCodes #12477

merged 1 commit into from
Aug 3, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 1, 2018

Resolves a long-standing TODO about supporting a Set in a chip input's separatorKeyCodes.

@crisbeto
feat(chips): allow set in separatorKeyCodes
d235835 
Resolves a long-standing TODO about supporting a `Set` in a chip input's `separatorKeyCodes`.
@crisbeto crisbeto added the target: minor This PR is targeted for the next minor release label Aug 1, 2018
@crisbeto crisbeto requested a review from jelbourn as a code owner August 1, 2018 21:18
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 1, 2018
jelbourn
jelbourn approved these changes Aug 1, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 1, 2018
@jelbourn jelbourn merged commit 170665a into angular:master Aug 3, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crisbeto @jelbourn @googlebot